Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unreachable panic triggered if using client::conn with the Version set to HTTP_2 #1770

Closed
seanmonstar opened this issue Feb 27, 2019 · 0 comments
Closed

unreachable panic triggered if using client::conn with the Version set to HTTP_2 #1770

seanmonstar opened this issue Feb 27, 2019 · 0 comments
Labels
A-client Area: client. A-http1 Area: HTTP/1 specific. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

While the Server and Client will both coerce Version::HTTP_2 to HTTP_11, the client::conn::SendRequest doesn't do that. Thus, this panic is triggered.

It seems best to just add a case for it just like there is in the server encode path.
@seanmonstar seanmonstar added C-bug Category: bug. Something is wrong. This is bad! A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-http1 Area: HTTP/1 specific. labels Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. A-http1 Area: HTTP/1 specific. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmonstar