Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C compilation without using nightly #2832

Closed
kevinburke opened this issue May 15, 2022 · 3 comments
Closed

C compilation without using nightly #2832

kevinburke opened this issue May 15, 2022 · 3 comments
Labels
A-ffi Area: ffi (C API) B-upstream Blocked: needs a change in a dependency or the compiler.

Comments

@kevinburke
Copy link
Contributor

I maintain a Homebrew formula that can be used to install rustls-ffi, Hyper, curl, git (and hopefully other software), using the Rust backends. You can view the repo and instructions here: https://github.com/kevinburke/homebrew-safe

I've had to pin the Hyper formula to 0.14.17 because the 0.14.18 release depends on the nightly Rust release, and Homebrew makes it difficult to install the nightly.

Because of this I've also had to pin curl at version 7.82, which is now two point releases behind.

I'm wondering if there's a time frame when I might be able to get back up to tip again - if it's possible to not have to depend on the nightly at some point in the near future.

@kevinburke kevinburke added the C-bug Category: bug. Something is wrong. This is bad! label May 15, 2022
@memoryruins
Copy link
Contributor

I'm wondering if there's a time frame when I might be able to get back up to tip again - if it's possible to not have to depend on the nightly at some point in the near future.

As far as I know, the only nightly feature hyper uses for the C API is rust-lang/cargo#10083. which was motivated by hyper's needs in #2685. It should be possible to use the first stable rust toolchain that feature ships with.

@seanmonstar
Copy link
Member

Yep exactly that. The cargo rustc --crate-type cdylib command line option (rust-lang/cargo#10083) needs to stabilize to be able to use it on a non-nightly toolchain.

@seanmonstar seanmonstar added B-upstream Blocked: needs a change in a dependency or the compiler. A-ffi Area: ffi (C API) and removed C-bug Category: bug. Something is wrong. This is bad! labels May 18, 2022
@nnethercote
Copy link
Contributor

Nightly hasn't been necessary since Rust 1.64.0 was released. See the build instructions in https://github.com/hyperium/hyper/blob/master/capi/README.md.

Which means this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ffi Area: ffi (C API) B-upstream Blocked: needs a change in a dependency or the compiler.
Projects
None yet
Development

No branches or pull requests

4 participants