Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminder: Upgrade header Protocols should support version #480

Closed
pyfisch opened this issue Apr 26, 2015 · 2 comments · Fixed by #499
Closed

Reminder: Upgrade header Protocols should support version #480

pyfisch opened this issue Apr 26, 2015 · 2 comments · Fixed by #499

Comments

@pyfisch
Copy link
Contributor

pyfisch commented Apr 26, 2015

As defined in http://tools.ietf.org/html/rfc7230#section-6.7 a protocol consists of a name and an optional version token.
@seanmonstar
Copy link
Member

I don't understand what the action is for this issue. Does the Upgrade header need to be changed?

@pyfisch
Copy link
Contributor Author

pyfisch commented Apr 30, 2015

Yes we need to change Upgrade header field. (What means "need" we can also keep it but do not implement the RFC)

The RFC says:

     Upgrade          = 1#protocol
     protocol         = protocol-name ["/" protocol-version]
     protocol-name    = token
     protocol-version = token

We do:

     Upgrade          = 1#protocol
     protocol         = text

@pyfisch pyfisch mentioned this issue May 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(headers): Parse Upgrade header protocols further
2 participants
@seanmonstar @pyfisch