fix(server): add poll_ready to Service and MakeService
#1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Feb 25, 2019
| @@ -26,6 +26,11 @@ pub trait Service { | |||
| /// The `Future` returned by this `Service`. | |||
| type Future: Future<Item=Response<Self::ResBody>, Error=Self::Error>; | |||
|
|
|||
| #[doc(hidden)] | |||
| fn poll_ready(&mut self) -> Poll<(), Self::Error> { | |||
There was a problem hiding this comment.
This should probably not be doc(hidden), but include similar wording to what it says in tower-service.
There was a problem hiding this comment.
I've added doc comment to them.
ubnt-intrepid
force-pushed
the
poll-ready
branch
from
9942b2c
to
88f8633
Compare
|
@seanmonstar do you think this would be a good time for hyper to move to the actual tower traits? |
|
@LucioFranco I think we are close! Switching completely is breaking change, so maybe should be bundled with other breaking changes (like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the method
poll_readytoServiceandMakeService, which provides the ability to these services for notifying the readiness whether to accept connections or requests.These methods corresponds to
tower_service::Service::poll_readyand prevents to ignore calling this method when using tower's services inhyper::Serverorhyper::server::conn::Connection.The added methods have the default implementation and has no effect on existing code that implements
Service/MakeServicedirectly.