Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose tonic::Request#into_parts() #1116

Closed
slinkydeveloper opened this issue Oct 18, 2022 · 2 comments · Fixed by #1118
Closed

Expose tonic::Request#into_parts() #1116

slinkydeveloper opened this issue Oct 18, 2022 · 2 comments · Fixed by #1118

Comments

@slinkydeveloper
Copy link
Contributor

Feature Request

Would It be possible to expose tonic::Request#into_parts() to get ownership on Metadata without additional cloning?

Crates

  • tonic

Motivation

Avoid copying Metadata when ownership is needed

Proposal

Change visibility of tonic::Request#into_parts() to pub.

Alternatives

At the moment my solution just involves copying all the Metadata map
@LucioFranco
Copy link
Member

Yeah, I am open to this idea. I would accept a PR for it.

@slinkydeveloper slinkydeveloper mentioned this issue Oct 19, 2022
Merged
@slinkydeveloper
Copy link
Contributor Author

I opened a PR here: #1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Request#into_parts and Request#from_parts slinkydeveloper/tonic
2 participants
@LucioFranco @slinkydeveloper