Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not panic while encoding oversized bodies #1142

Merged
merged 2 commits into from
Nov 10, 2022
Merged

fix: do not panic while encoding oversized bodies #1142

merged 2 commits into from
Nov 10, 2022

Conversation

crepererum
Copy link
Contributor

Motivation

Fixes #1141.

Solution

Replace assertion w/ an ordinary error path.

LucioFranco
LucioFranco approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this seems extremely logical and a good change: :D

@LucioFranco LucioFranco merged commit 33e22bb into hyperium:master Nov 10, 2022
@LucioFranco LucioFranco mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning body w/ >4GB data panics
2 participants
@crepererum @LucioFranco