Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeGen8uilder typo #1166

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

NAlexPear
Copy link
Contributor

@NAlexPear NAlexPear commented Nov 28, 2022

Changes CodeGen8uilder to CodeGenBuilder in tonic_build. Fixes #1165.

Motivation

While 8uilder looks super l33t, it's not consistent with the documentation.

Solution

sed -i 's/CodeGen8uilder/CodeGenBuilder/g'

@LucioFranco
Copy link
Member

Oh wow, not sure how I didn't see that....hahaha...maybe I need to bump my font size LOL

@LucioFranco LucioFranco merged commit c7476ff into hyperium:master Nov 29, 2022
@LucioFranco
Copy link
Member

Ok I have a release PR going, and I will yank the tonic-build 0.8.3 and push a 0.8.4 thanks for catching this! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeGen8uilder should be CodeGenBuilder
2 participants