feat(types): Add gRPC Richer Error Model support (QuotaFailure) #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following implementation at flemosr/tonic-richer-error.
LucioFranco
reviewed
Dec 20, 2022
| @@ -120,18 +166,23 @@ impl ErrorDetails { | |||
| } | |||
|
|
|||
| /// Get [`RetryInfo`] details, if any | |||
| pub fn retry_info(&self) -> Option<RetryInfo> { | |||
| self.retry_info.clone() | |||
| pub fn retry_info(&self) -> &Option<RetryInfo> { | |||
There was a problem hiding this comment.
Should these be Option<&Foo>? This is also a breaking change so maybe we should do this later and save it?
There was a problem hiding this comment.
I did not see that v0.6.1 was released 😅 . Sorry about that. Yes, better to do this later, I pushed a commit to revert this change. Thanks!
LucioFranco
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The gRPC Richer Error Model is quite useful to send additional feedback to clients, and is supported by many gRPC libraries in other languages.
Solution
This PR continues the work initiated in #1068, building on the changes made in #1179. It adds support for the
QuotaFailurestandard error message type totonic-types.