feat: Add gRPC interceptors #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces proper gRPC interceptors that are avilable regardless of the transport used. Each codegen service now produces an additional method called `with_interceptor` that accepts a `Interceptor`. All examples have been updated to use this new style and interop has a custom `tower::Service` middleware to echo the headers. There is also a new `interceptor` example that shows basic usage.
alce
reviewed
Jan 14, 2020
alce
reviewed
Jan 14, 2020
alce
reviewed
Jan 14, 2020
alce
reviewed
Jan 14, 2020
| let inner = tonic::client::Grpc::with_interceptor(inner, interceptor); | ||
| Self { inner } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you think it would be worth it to use a builder-like pattern instead of whit_interceptor constructor? Same for the server.
There was a problem hiding this comment.
Since there is only one config option as of now, I wanted to keep this simple, I think if we add another option in the future we go with a builder.
alce
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces proper gRPC interceptors that are avilable
regardless of the transport used. Each codegen service now produces an
additional method called
with_interceptorthat accepts aInterceptor.All examples have been updated to use this new style and interop has a
custom
tower::Servicemiddleware to echo the headers. There is also anew
interceptorexample that shows basic usage.