Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Add content-type for generated unimplemented service #441

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

edrevo
Copy link
Contributor

@edrevo edrevo commented Aug 30, 2020

Motivation

According to the spec content-type should be set. Related to #434

Solution

Add the application/grpc content-type header.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right! I totally forgot we had this here! 😅

Thanks for digging into this!!

@LucioFranco LucioFranco changed the title fix(build): Add content-type for Unimplemented fix(build): Add content-type for generated unimplemented service Aug 31, 2020
@LucioFranco LucioFranco merged commit 62c1230 into hyperium:master Aug 31, 2020
@edrevo edrevo deleted the fix-content-type-unimplemented branch August 31, 2020 20:52
@wllenyj
Copy link

wllenyj commented Jan 11, 2021

@LucioFranco When will a new version be released with this patch. i can only use cargo patch to github master to solve this problem now.

Thanks a lot.

@LucioFranco
Copy link
Member

New version is hopefully planned for this week, we got a new version of tower out last week which was a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants