feat(tonic): pass trace_fn the request rather than just the headers
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Server::trace_fn` would receive `&HeaderMap` which meant you couldn't add things like the URI to the span. With this change it now receives `&http::Request<()>`. It doesn't receive the body since that requires an additional generic parameter which spreads to a lot of places. There also isn't much you can do with the body of a borrowed `http::Request` anyways so its probably fine.
LucioFranco
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Server::trace_fnwould receive&HeaderMapwhich meant youcouldn't add things like the URI to the span.
With this change it now receives
&http::Request<()>. It doesn'treceive the body since that requires an additional generic parameter
which spreads to a lot of places. There also isn't much you can do with
the body of a borrowed
http::Requestanyways so its probably fine.Fixes #630