feat(build): support adding attributes to clients and servers #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cab
commented
Jun 17, 2021
| } else if pattern == path { | ||
| true | ||
| } else { | ||
| let pattern_segments = pattern.split('.').collect::<Vec<_>>(); |
There was a problem hiding this comment.
LucioFranco
approved these changes
Jul 2, 2021
davidpdrsn
changed the title
cab
force-pushed
the
service-attrs
branch
2 times, most recently
from
8bb9130
to
68fae34
Compare
davidpdrsn
reviewed
Jul 8, 2021
cab
force-pushed
the
service-attrs
branch
2 times, most recently
from
00c6df6
to
37ccbbd
Compare
davidpdrsn
approved these changes
Jul 8, 2021
cab
force-pushed
the
service-attrs
branch
2 times, most recently
from
755b989
to
55a7554
Compare
LucioFranco
reviewed
Jul 8, 2021
tonic-build/src/lib.rs
Outdated
Comment on lines
162
to
165
| /// `mod` attributes. | ||
| pub module: Vec<(String, String)>, | ||
| /// `struct` attributes. | ||
| pub structure: Vec<(String, String)>, |
There was a problem hiding this comment.
why do these need to be public?
LucioFranco
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements #504.
Having the ability to add attributes to generated servers and clients allows things like feature gating or deriving additional service functionality without the need for a fork.
Solution
This PR only changes
tonic-build. Four new methods are added toBuilder:server_mod_attributemodwrapping the server implementation.server_attributestruct.client_mod_attributemodwrapping the client implementation.client_attributestruct.These are all optional values. Calling them more than once is additive.
Each method accepts a
patternand anattribute.patternfollows similar rules astonic's attribute matching rules.If
patternmatches for a given service, the respectiveattributevalues are parsed assyn::Attributes and added to the generated code inserver::generateandclient::generate.