fix(codec): Fix streaming reponses w/ many status #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Jun 21, 2021
davidpdrsn
approved these changes
Jun 22, 2021
alexrudy
added a commit
to alexrudy/tonic
that referenced
this pull request
Apr 16, 2024
According to [hyperium#689](hyperium#689) streams should end after the first error. Therefore, when we find an error in the response step, discard the trailers so that the stream ends.
alexrudy
added a commit
to alexrudy/tonic
that referenced
this pull request
May 20, 2024
According to [hyperium#689](hyperium#689) streams should end after the first error. Therefore, when we find an error in the response step, discard the trailers so that the stream ends.
alexrudy
added a commit
to alexrudy/tonic
that referenced
this pull request
May 21, 2024
According to [hyperium#689](hyperium#689) streams should end after the first error. Therefore, when we find an error in the response step, discard the trailers so that the stream ends.
alexrudy
added a commit
to alexrudy/tonic
that referenced
this pull request
May 26, 2024
According to [hyperium#689](hyperium#689) streams should end after the first error. Therefore, when we find an error in the response step, discard the trailers so that the stream ends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug found in #681 where sending a second status code in a stream would return an
Unknownstatus code w/ the message that there was nogrpc-header. From the grpc-h2 spec after the first status code returned in a streaming response we must end the stream. This change introduces the behavior withinfer_grpc_statusfrom trailers to map ahttp::StatusCode::OKto a empty/ended trailer stream.Closes #681