Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server - Automated Refactoring #14

Open
jdesrosiers opened this issue Feb 28, 2024 · 2 comments
Open

Server - Automated Refactoring #14

jdesrosiers opened this issue Feb 28, 2024 · 2 comments
Labels

Comments

@jdesrosiers
Copy link
Collaborator

I'm not sure what support the lsp has for automated refactorings, but that would be a really powerful thing feature if it does.

Refactoring ideas:

  • Extract schema resource (to it's own document)
  • Extract subschema (to definitions)
  • Inline schema resource
  • Inline subschema
  • Implication to if/then
  • if/then to dependentSchemas
  • if/then to dependentRequired
  • dependentSchemas to dependentRequired
  • not/item/not to contains
@jdesrosiers jdesrosiers changed the title Server - Refactoring Server - Automated Refactoring Mar 22, 2024
@arpitkuriyal
Copy link

Hello @jdesrosiers, I’ve been exploring JSON Schema tools and validators, and I’m interested in contributing to this issue as it help me to explore the json-schema-language-tool. Could you please assign this issue to me? Looking forward to working on it!

@jdesrosiers
Copy link
Collaborator Author

Sure, @arpitkuriyal, it'd be great if you looked into this. Keep in mind that I have no idea how this is going to work and what's possible and what isn't. So this will take a lot of research and trial and error on your part. I'll help you figure things out, but I don't have a solution in mind. You're jumping the deep end with this one.

I think we can use the new Github sub-issue feature to break this down. I think "Inline subschema (to definitions)" is probably the simplest case and a good one to start with. I'll create that sub-issue and assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants