Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: CLI does not work with advanced and defaultFallbackRoutingIsm #4440

Open
ltyu opened this issue Sep 5, 2024 · 0 comments
Open

bug: CLI does not work with advanced and defaultFallbackRoutingIsm #4440

ltyu opened this issue Sep 5, 2024 · 0 comments
Assignees
@ltyu
Labels
CLI

Comments

@ltyu
Copy link
Contributor

ltyu commented Sep 5, 2024

Problem

Currently when a user uses hyperlane warp init --advanced and they select defaultFallbackRoutingIsm, they are always forced to pick a domain. This is incorrect because they should be able to pick none.

Also, there the owner address is set to an empty string, which will fail Zod validations

Solution

  • Update the requireNumber of runMultiChainSelectionStep() to 0
  • Update the empty owner string to AddressZero (confirm if this is intended)
@ltyu ltyu added the CLI label Sep 5, 2024
@ltyu ltyu self-assigned this Sep 5, 2024
@ltyu ltyu changed the title CLI does not work with advanced and defaultFallbackRoutingIsm bug: CLI does not work with advanced and defaultFallbackRoutingIsm Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltyu ltyu

Labels
CLI
Projects
Hyperlane Tasks
Status: Sprint
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ltyu