Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

[Keys] consider making eris-keys key files compatible with ethereum clients #334

Closed
compleatang opened this issue Oct 13, 2016 · 2 comments

Comments

@compleatang
Copy link
Contributor

@Gustav-Simonsson commented on Wed Sep 09 2015

To get compatibility between all Ethereum clients we worked out a spec for a common key file: https://github.com/ethereum/wiki/wiki/Web3-Secret-Storage-Definition

While GCM is nice and we probably should have gone with it instead of CTR + MAC, for the moment Ethereum clients generate key files with CTR.

However the current go-ethereum code supports multiple key formats for backwards compatibility; both scrypt and PBKDF2 for KDF and both CTR and CBC for encryption mode. This could be extended to support GCM if defined by the cipher field present in version 3 (latest) of the spec.

Would recommend we strive for compatibility between platforms here. This could be done quite easily if eris-keys rebases on go-ethereum's crypto/key_store_passphrase.go to pickup version 3 of it's key file format and defines it's GCM mode usage by setting the cipher field to something like aes-128-gcm (we use aes-128-ctr to denote CTR mode)


@ebuchman commented on Wed Sep 09 2015

yes I would love to do this. thanks for the details.


@benjaminbollen commented on Tue May 10 2016

@zramsay @VoR0220 @AFDudley shall we post progress on this issue here ?


@VoR0220 commented on Tue May 10 2016

yesh

@compleatang compleatang changed the title [Crypto] consider making eris-keys key files compatible with ethereum clients [Keys] consider making eris-keys key files compatible with ethereum clients Oct 13, 2016
@compleatang compleatang added this to the 0.17.0 milestone Oct 13, 2016
@silasdavis
Copy link
Contributor

I need to learn some more crypto acronyms, but the intention of this ticket seems like a good one.

@silasdavis
Copy link
Contributor

I am inclined to agree with @ebuchman here: tendermint/go-crypto#13. Hoard also makes use of OpenPGP armor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants