Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Ensure StreamSender enforces Exchange Rates #261

Closed
sappenin opened this issue Sep 18, 2019 · 3 comments
Closed

Ensure StreamSender enforces Exchange Rates #261

sappenin opened this issue Sep 18, 2019 · 3 comments
Assignees
Labels
stream Issues affecting the STREAM protocol in IL-RFC-29 v1.0
Milestone

Comments

@sappenin
Copy link
Contributor

sappenin commented Sep 18, 2019

See comments here: interledger/interledger-rs#273

Specifically, this TODO in the Rust code (which will have a corresponding entry int he Java code once committed to master).

Reference this portion of IL-RFC-29 for Exchange Rates.

@sappenin
Copy link
Contributor Author

sappenin commented Sep 27, 2019

This fix required two changes. One to the StreamReceiver (fixed in #285) and a separate fix in the StreamSender.

The work for the StreamSender is more formally defined in #291, so we should consider closing this task in-favor of that one.

@sappenin
Copy link
Contributor Author

See #291

@sappenin
Copy link
Contributor Author

@theotherian there is a new comment in the associated RUST issue from Kincaid. Let’s look at our implementation to confirm we’re accounting for this use-case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stream Issues affecting the STREAM protocol in IL-RFC-29 v1.0
Development

No branches or pull requests

2 participants