Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Implement non-fixture unit tests for STREAM #350

Open
sappenin opened this issue Oct 17, 2019 · 0 comments
Open

Implement non-fixture unit tests for STREAM #350

sappenin opened this issue Oct 17, 2019 · 0 comments
Labels
good first issue stream Issues affecting the STREAM protocol in IL-RFC-29 test coverage

Comments

@sappenin
Copy link
Contributor

The JS implementation of STREAM has some unit tests that we should ensure are covered in Quilt. Namely, these include the non-fixture tests found in https://github.com/interledgerjs/ilp-protocol-stream/blob/master/test/packet.test.ts as well as the STREAM tests here: https://github.com/interledgerjs/ilp-protocol-stream/blob/master/test/stream.test.ts

(Note, some or all of these cases might be covered or may not apply due to implementation differences, so it's worth doing some investigation first before blindly re-implementing the JS test cases)

@sappenin sappenin added stream Issues affecting the STREAM protocol in IL-RFC-29 test coverage v1.1 labels Oct 17, 2019
@sappenin sappenin removed the v1.1 label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue stream Issues affecting the STREAM protocol in IL-RFC-29 test coverage
Development

No branches or pull requests

1 participant