Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Migrate from warp to axum/actix #3776

Closed
ilchu opened this issue Aug 2, 2023 · 2 comments · Fixed by #4718
Closed

[refactor] Migrate from warp to axum/actix #3776

ilchu opened this issue Aug 2, 2023 · 2 comments · Fixed by #4718
Assignees
Labels
dependencies Pull requests that update a dependency file iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality research

Comments

@ilchu
Copy link
Contributor

ilchu commented Aug 2, 2023

Feature request

Replace warp crate to a more batteries included kind of web framework, main candidates being axum or actix. Do some researching/benchmark to determine what's better, if possible.

Motivation

Currently the warp crate is used throughout the cli and version parts of the codebase, but it's been known as a pain point for a while with unwieldy filter type signatures occupying the whole screen and awkward proc macro metaprogramming to reach our goals.

Who can help?

@appetrosyan

@ilchu ilchu added iroha2-dev The re-implementation of a BFT hyperledger in RUST research Refactor Improvement to overall code quality dependencies Pull requests that update a dependency file labels Aug 2, 2023
@ilchu ilchu self-assigned this Aug 2, 2023
@0x009922
Copy link
Contributor

0x009922 commented Sep 1, 2023

I guess it will automatically close #2430

@DCNick3
Copy link
Contributor

DCNick3 commented Oct 20, 2023

In #3983 (comment) it was suggested to postpone more proper content type negotiation until we move to actix/axum. Don't forget to handle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants