-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable configuration #4282
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would prefer config to have private fields with constructors and getters for the following reasons:
setters we can but don't even have to have. I wouldn't mind if the config structs were completely immutable. If we do decide to have setters we can put validation logic into them. But I would prefer to not have setters at least atm
The text was updated successfully, but these errors were encountered: