Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Permission::id #4702

Open
mversic opened this issue Jun 6, 2024 · 1 comment
Open

Remove Permission::id #4702

mversic opened this issue Jun 6, 2024 · 1 comment
Assignees
@Erigara
Labels
api-changes Changes in the API for client libraries Chore This is a small task that can be done at any point in time and is easier than others

Comments

@mversic
Copy link
Contributor

mversic commented Jun 6, 2024

Following the discussion here in #4645 we should try to do the same with permissions since iroha_core doesn't need to know their ids. Consistency during executor migration then becomes responsibility of the executor
@mversic mversic added api-changes Changes in the API for client libraries Chore This is a small task that can be done at any point in time and is easier than others labels Jun 6, 2024
@mversic mversic mentioned this issue Jun 6, 2024
Merged
5 tasks
@mversic
Copy link
Contributor Author

mversic commented Jun 10, 2024

also remove PermissionId type. Permissions cannot be Identifiable

@mversic mversic added this to Iroha Oct 10, 2024
@mversic mversic moved this to Required for MVP in Iroha Oct 10, 2024
@Erigara Erigara self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
api-changes Changes in the API for client libraries Chore This is a small task that can be done at any point in time and is easier than others
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erigara @mversic