Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax DID validation on prover_did on a credential request #307

Closed
ianco opened this issue Jan 23, 2024 · 3 comments · Fixed by #310
Closed

Relax DID validation on prover_did on a credential request #307

ianco opened this issue Jan 23, 2024 · 3 comments · Fixed by #310
Assignees

Comments

@ianco
Copy link
Member

ianco commented Jan 23, 2024

Prover DID can be any did, for example did:peer:

"prover_did": "did:peer:2.Vz6MksjZKAGZbiZvWaXucPoxTpRa6U2QgaqvbrzPq9A2Kcwpu.SeyJpZCI6IiNkaWRjb21tLTAiLCJ0IjoiZGlkLWNvbW11bmljYXRpb24iLCJwcmlvcml0eSI6MCwicmVjaXBpZW50S2V5cyI6WyIja2V5LTEiXSwiciI6W10sInMiOiJodHRwOi8vaG9zdC5kb2NrZXIuaW50ZXJuYWw6ODAzMCJ9"

This currently fails validation, and should pass.

The prover_did doesn't need to be a DID at all, so we could potentially remove this validation completely.

See hyperledger/aries-cloudagent-python#2714

@swcurran
Copy link
Member

The validation is in anoncreds-rs? Ah…interesting.

@TimoGlastra
Copy link
Member

@swcurran
Copy link
Member

@assigned to @andrewwhitehead -- a high priority one to get completed and into a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants