Poetry PR related fix for Issue 2459 #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
|
@swcurran - can you request reviews from whomever you feel is best qualified? |
|
Done — but I’ll try to run the PR ASAP and approve. Well, I’ll approve if it really works. Great job on the documentation/explanation. Much, much appreciated! |
swcurran
approved these changes
Sep 21, 2023
|
@usingtechnology nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACA-PY Issue 2459 - tests failing
Addressing the failing tests in AATH after the move to
poetry(see PR 2436). The issue is notpoetryor the set of depedency changes, but rather the elimination ofbin/acapyshell script and it's removal from the dependency installation (usingpiporpoetry). The script is no longer needed in the base images andacapyis started by other means. However, AATH is expecting that script and references it directly in the backchannel.I decided to leave AATH as close to original as is (ie. not using
poetryto install ACA-Py) and addressed the issue by adding thebin/acapyscript to this repo and having AATH add it to its image.ACA-Py Issue 2460 - default to
askarAlso in this PR I am including the update to make
askarthe default storage/wallet type. Was simple enough and simplified running the tests. I touched the documentation in case someone needs to revert toindy.