Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature afj/credo backchannel enhancements #842

Merged

Conversation

nodlesh
Copy link
Contributor

@nodlesh nodlesh commented Jun 25, 2024

This PR creates a new backchannel for Credo, leaving the AFJ one in place for now. It expands the backchannel further for more supported protocols of Credo(though the new tests are not running in this PR).

This PR also adds a Dev Container for the Credo Backchannel.

All historical AFJ tests are now working with Credo. Runsets have been created for credo with ACA-Py and VCX. Credo Allure projects are created, and the gen-interop script has been updated to reference credo instead of aft.

The removal of the AFJ runsets and the AFJ backchannel will happen in a separate PR after we have a few successful runs of Credo. Though the afj runsets have been set to skip, so they will not run in the interop test pipeline.

This PR also doesn't have new tests outside of the historical AFJ tests. They need a little more work and will come in a separate PR. This PR is getting too large as it is.

To test this PR you can run the following.
./manage runset credo
./manage runset ariesvcx-credo
./manage runset credo-ariesvcx
./manage runset acapy-credo
./manage runset credo-acapy

@nodlesh nodlesh force-pushed the feature-afj-bc-enhancements branch 2 times, most recently from 069cee2 to 48610f6 Compare July 8, 2024 12:49
@nodlesh nodlesh force-pushed the feature-afj-bc-enhancements branch from c81dec8 to 3043d23 Compare July 16, 2024 15:39
@nodlesh nodlesh force-pushed the feature-afj-bc-enhancements branch from e5875b6 to bc999e8 Compare August 9, 2024 17:21
@nodlesh nodlesh force-pushed the feature-afj-bc-enhancements branch from c0e0f1a to b0e942e Compare August 23, 2024 19:40
@swcurran
Copy link
Contributor

How’s the progress on this? Getting close?

@nodlesh
Copy link
Contributor Author

nodlesh commented Aug 23, 2024

I thought I was close a few weeks ago but got hung up solving an issue with starting a server with some newer TsED libraries in the upgrade of the Credo Backchannel. I'd like to say I'm close now. I've solved the issues in the Credo backchannel that were causing the schema errors in the AFJ backchannel seen in the nightly test runs for a while. I believe there is just a credential issuance problem I'm dealing with right now. I'd say I'm 3-5 days away from having credo running in the interop pipeline and retiring the AFJ runs in the pipeline. I'm away next week so it will be into Sept.

Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
@nodlesh nodlesh marked this pull request as ready for review September 6, 2024 13:46
@nodlesh
Copy link
Contributor Author

nodlesh commented Sep 6, 2024

I'm having a couple of failures in the ariesvcx-credo runset that I'm investigating.

@swcurran
Copy link
Contributor

swcurran commented Sep 6, 2024

Running the tests now.

When this is merged, are we adding credo as a new backchannel in the results in Allure and so to https://aries-interop.info, or does this push its results to the “javascript” Allure results so everything stays the same?

@nodlesh
Copy link
Contributor Author

nodlesh commented Sep 6, 2024

If I understand how the interop.info results are generated, I think it will list as credo not afj. The credo projects are already created in Allure.

@swcurran
Copy link
Contributor

swcurran commented Sep 6, 2024

OK — I see how the results are pushed to allure. I’ll adjust the script configuration to get the credo results instead of the AFJ (aka “javascript”) ones.

Here is the results from the ACA-Py / Credo tests I ran locally. Look right?

4 features passed, 2 failed, 9 skipped
25 scenarios passed, 5 failed, 130 skipped
198 steps passed, 5 failed, 1180 skipped, 0 undefined
Took 12m11.948s

swcurran
swcurran previously approved these changes Sep 6, 2024
@swcurran
Copy link
Contributor

swcurran commented Sep 6, 2024

Looks great!! I’ll leave it to you to push the merge button.

@nodlesh
Copy link
Contributor Author

nodlesh commented Sep 6, 2024

I could be wrong, but I think I've adjusted the scripts to get the credo results instead of AFJ. Check the gen-interop.sh changes in this PR.

My ACA-Py - Credo runset only has 2 failures. These are not failing when running in VS code and the Dev Container. Looking at that now.

I think there is an issue with VCX talking to Credo, I think the problem is on the VCX side. Will have to engage the VCX guys.

@swcurran
Copy link
Contributor

swcurran commented Sep 6, 2024

The gen-interop change looks good.

Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
@nodlesh
Copy link
Contributor Author

nodlesh commented Sep 6, 2024

There are still a couple of failures here across the runsets, but I think they are problems with the frameworks, Credo and VCX mainly. I'm merging, and will follow up with them on the remaining issues.

@nodlesh nodlesh merged commit 9f098ca into openwallet-foundation:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants