Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade codegen tools used in generate-open-api-specols #2899

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Apr 17, 2024

Upgrades swagger-codegen-cli and openapi-generator-cli to latest releases.

The swagger one makes no difference to the spec, but the openapi one has some improvements.

e.g. nested models used to reference to subschemas:

      "InvitationRecord" : {
        "properties" : {
...
          "invitation" : {
            "$ref" : "#/components/schemas/InvitationRecord_invitation"
          },

...

      "InvitationRecord_invitation" : {
        "allOf" : [ {
          "$ref" : "#/components/schemas/InvitationMessage"
        } ],
        "description" : "Out of band invitation message",
        "type" : "object"
      },

which now references directly:

      "InvitationRecord" : {
        "properties" : {
...
          "invitation" : {
            "allOf" : [ {
              "$ref" : "#/components/schemas/InvitationMessage"
            } ],
            "description" : "Out of band invitation message",
            "type" : "object"
          },

Note: there's a "Connection state" enum field which was defined from a python set, so its ordering would vary every time the spec is regenerated. I converted that to a sorted list, so its ordering will remain consistent.

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 marked this pull request as draft April 17, 2024 13:16
@ff137 ff137 force-pushed the update/openapi-codegen-tools branch from 4d2b2d7 to 50a3cbc Compare April 17, 2024 13:16
… not vary every time spec is regenerated

Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 force-pushed the update/openapi-codegen-tools branch from 50a3cbc to 2bf3313 Compare April 17, 2024 13:37
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ff137 ff137 marked this pull request as ready for review April 17, 2024 16:31
@dbluhm dbluhm merged commit 9aa910b into openwallet-foundation:main Apr 17, 2024
8 checks passed
@dbluhm dbluhm mentioned this pull request Apr 17, 2024
@ff137 ff137 deleted the update/openapi-codegen-tools branch April 18, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants