Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interop): overly strict validation #2943

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(interop): overly strict validation #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29c5468
fix(interop): overly strict validation
dbluhm May 10, 2024
c690369
Merge branch 'main' into fix/interop/overly-strict-validation
dbluhm May 20, 2024
dc4cab3
Merge branch 'main' into fix/interop/overly-strict-validation
dbluhm May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions aries_cloudagent/protocols/present_proof/dif/pres_exch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,12 +824,10 @@ class Meta:

id = fields.Str(
required=False,
validate=UUID4_VALIDATE,
metadata={"description": "ID", "example": UUID4_EXAMPLE},
)
definition_id = fields.Str(
required=False,
validate=UUID4_VALIDATE,
metadata={"description": "DefinitionID", "example": UUID4_EXAMPLE},
)
descriptor_maps = fields.List(
Expand Down
3 changes: 1 addition & 2 deletions aries_cloudagent/protocols/present_proof/v2_0/formats/dif/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from typing import Mapping, Optional, Sequence, Tuple
from uuid import uuid4

from marshmallow import RAISE

from ......messaging.base_handler import BaseResponder
from ......messaging.decorators.attach_decorator import AttachDecorator
Expand Down Expand Up @@ -75,7 +74,7 @@ def validate_fields(cls, message_type: str, attachment_data: Mapping):
Schema = mapping[message_type]

# Validate, throw if not valid
Schema(unknown=RAISE).load(attachment_data)
Schema().load(attachment_data)

def get_format_identifier(self, message_type: str) -> str:
"""Get attachment format identifier for format and message combination.
Expand Down
3 changes: 0 additions & 3 deletions aries_cloudagent/vc/vc_ld/models/linked_data_proof.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ class Meta:

domain = fields.Str(
required=False,
# TODO the domain can be more than a Uri, provide a less restrictive validation
# https://www.w3.org/TR/vc-data-integrity/#defn-domain
validate=Uri(),
metadata={
"description": (
"A string value specifying the restricted domain of the signature."
Expand Down