Redundant rpc permission checks when authentication enabled

[magooster]

Description

When authentication is enabled Besu will check all possible rpc method permissions for a user when authorizing an rpc request.

Expected behavior: [What you expect to happen]

Authorization check should return once a suitable permission has been identified.

Actual behavior: [What actually happens]

Besu checks every rpc permission

If debug is set get some confusing log entries as well if user has wider permissions e.g. ["*:*"]

2020-06-19 19:42:57.073+01:00 | vert.x-worker-thread-9 | DEBUG | JsonRpcHttpService | JSON-RPC request -> priv_getTransactionReceipt
2020-06-19 19:42:57.073+01:00 | vert.x-worker-thread-9 | DEBUG | JWTUser | User has no permission [priv:getTransactionReceipt]
2020-06-19 19:42:57.073+01:00 | vert.x-worker-thread-9 | DEBUG | JWTUser | User has no permission [priv:*]

If user has valid permissions I don't need to see those...

Frequency: [What percentage of the time does it occur?]

Whenever authentication is enabled

Versions (Add all that apply)

• Software version: <=1.4.7

Additional Information

See the isPermitted method in AuthenticationUtils.java

Note the order from getPermissions in JsonRpcMethod.java is not in terms of narrowing permissions, actually retruns

"*:*"
"group:method"
"group:*"

[MadelineMurray]

hi @magooster - the PR to fix this has been merged now and will be available in the next release. Are you happy for this to be closed?

[magooster]

Sure, thanks for the update