-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
During BDDTests decomposing takes a lot longer than it should. This is due to the containers are started using `bash -c "<cmd>"` which does not pass on signals to the specified command. Hence, docker-compose sends a SIGTERM which is ignored and after a timeout, sends SIGKILL. Changing the invocations to `bash -c "exec <cmd>"` ensures the command receives the signals and terminates in a timely manner. This change improves BDDTest times by about 5 minutes. Change-Id: Id0504809740c948758f49ff08961cb377f0a8634 Signed-off-by: Julian Carrivick <cjulian@au1.ibm.com>
- Loading branch information
1 parent
c9a0166
commit 664facf
Showing
3 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,5 +16,5 @@ else | |
echo "No membersrvc to wait for, starting immediately" | ||
fi | ||
|
||
peer node start | ||
exec peer node start | ||
|