Implement 'osnadmin channel info' subcommand and update tests #4892
Conversation
Signed-off-by: Priyansu Rout <priyansurout192004@gmail.com>
Signed-off-by: Priyansu Rout <priyansurout192004@gmail.com>
Signed-off-by: Priyansu Rout <priyansurout192004@gmail.com>
Priyansurout
force-pushed
the
add-info-command
branch
from
8306268
to
e95740a
Compare
Signed-off-by: Priyansu Rout <priyansurout192004@gmail.com>
Signed-off-by: Priyansu Rout <priyansurout192004@gmail.com>
Priyansurout
force-pushed
the
add-info-command
branch
from
548a688
to
ebc72d5
Compare
There was a problem hiding this comment.
You got a check failure because anytime you change commands, you need to regenerate the doc to match.
See the instructions at
https://github.com/hyperledger/fabric/blob/main/docs/source/docs_guide.md#commands-reference-updates
Basically, the command help will be called when you regenerate the doc with each of the subcommands (including the new one which needs to be added in scripts/generateHelpDocs.sh), and this help text will be injected into the osnadminchannel.md doc topic which also needs to be included in the pull request.
You'll also need to add some text to the doc topic preamble and postscript.
To better understand, you can look at the commit that added the initial osnadmin help doc. This will show all the updates that are needed.
1e90c88
| info := channel.Command("info", "Get detailed information about a specific channel.") | ||
| infoChannelID := info.Flag("channelID", "Channel ID").Short('c').Required().String() |
There was a problem hiding this comment.
I'm thinking we can do this in a backward compatible way.
Keep the support for passing channel id to list with this line:
listChannelID := list.Flag("channelID", "Channel ID").Short('c').String()
Then add an entirely new "info" command.
Change the function osnadmin.ListSingleChannel() to osnadmin.Info() and have both of them call it.
The help text doesn't need to mention that you can pass channel id to list command anymore, but keep the functionality there so that any existing users that depend on it don't break.
Implemented the
osnadmin channel infosubcommand to retrieve detailed information about a specific channel from an Ordering Service Node (OSN). This involved modifying the CLI commands and adding corresponding functionality to interact with the channel participation API.Type of change
Implemented the
osnadmin channel infosubcommand to retrieve detailed information about a specific channel from an Ordering Service Node (OSN).infosubcommand underosnadmin channelto support querying individual channel details.Closes #4890