Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Introducing 'Security' section #374

Closed
wants to merge 63 commits into from
Closed

[docs] Introducing 'Security' section #374

wants to merge 63 commits into from

Conversation

yamkovoy
Copy link
Contributor

@yamkovoy yamkovoy commented Aug 14, 2023 •
edited
Loading

Description

Introducing the "Security" section of the documentation. The original documentation—PR #332—has been split for the sake of granularity.

Changes:

Notes

  • The "Password Security" topic is planned to be a part of the next PR.

@yamkovoy
[docs] hyperledger-iroha#332: Introducing 'Security' section
7e71a23 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@vercel
Copy link

vercel bot commented Aug 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iroha-2-docs ❌ Failed (Inspect) Sep 25, 2023 1:18pm

@yamkovoy yamkovoy marked this pull request as draft August 14, 2023 17:57
@yamkovoy yamkovoy marked this pull request as ready for review August 15, 2023 14:00
@yamkovoy
[docs] hyperledger-iroha#332: Changes and fixes
c14ec21 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@yamkovoy
[docs] hyperledger-iroha#332: Formatting fixes
1e657ff 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@yamkovoy
[docs] hyperledger-iroha#332: Fixed links
3aec98c 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@yamkovoy
Merge branch 'security-section-update' of https://github.com/yamkovoy…
a9b19d7 
…/iroha-2-docs into security-section-update
WRRicht3r
WRRicht3r requested changes Aug 21, 2023
View reviewed changes
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/security-principles.md Outdated Show resolved Hide resolved
src/guide/security/security-principles.md Outdated Show resolved Hide resolved
src/guide/security/storing-cryptographic-keys.md Outdated Show resolved Hide resolved
appetrosyan
appetrosyan suggested changes Aug 21, 2023
View reviewed changes
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
appetrosyan
appetrosyan reviewed Aug 21, 2023
View reviewed changes
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Show resolved Hide resolved
6r1d and others added 2 commits August 22, 2023 02:23
@6r1d @appetrosyan
Update src/guide/security/operational-security.md
2606f0e 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Victor <vic.6r1d@gmail.com>
@6r1d @appetrosyan
Update src/guide/security/security-principles.md
1f5773d 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Victor <vic.6r1d@gmail.com>
@6r1d @appetrosyan
Update src/guide/security/security-principles.md
dc38036 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Victor <vic.6r1d@gmail.com>
@6r1d @appetrosyan
Update src/guide/security/security-principles.md
32c15b1 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Victor <vic.6r1d@gmail.com>
@6r1d @appetrosyan
Update src/guide/security/operational-security.md
3850d24 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Victor <vic.6r1d@gmail.com>
0x009922
0x009922 reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cannot be built, and has a set of issues when you look into it in a rendered view. I would mark this PR as draft, and would like to solve some technical problems.

src/guide/security/generating-cryptographic-keys.md Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/storing-cryptographic-keys.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Outdated Show resolved Hide resolved
src/guide/security/generating-cryptographic-keys.md Outdated Show resolved Hide resolved
@0x009922 0x009922 marked this pull request as draft August 22, 2023 05:09
@0x009922
Copy link
Contributor

Also, there are references of KeePassXC screenshots, but the screenshots themselves do not exist.

6r1d
6r1d suggested changes Aug 22, 2023
View reviewed changes
src/guide/security/security-principles.md Show resolved Hide resolved
src/guide/security/keys-for-network-deployment.md Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
src/guide/security/operational-security.md Outdated Show resolved Hide resolved
@yamkovoy @appetrosyan
Update src/guide/security/generating-cryptographic-keys.md
9d68215 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com>
@yamkovoy @appetrosyan
Update src/guide/security/generating-cryptographic-keys.md
5f621be 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com>
@WRRicht3r WRRicht3r self-requested a review September 19, 2023 08:42
WRRicht3r
WRRicht3r approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@WRRicht3r WRRicht3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending all comments are addressed.
Thanks

yamkovoy
yamkovoy commented Sep 25, 2023
View reviewed changes
Copy link
Contributor Author

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments in commit 90e2f58

yamkovoy
yamkovoy commented Sep 25, 2023
View reviewed changes
Copy link
Contributor Author

@yamkovoy yamkovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and addressed

@yamkovoy
Addressed remaining comments, minor fixes
b27e993 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@yamkovoy yamkovoy requested a review from 6r1d September 25, 2023 13:02
@yamkovoy
Added missing screenshots
ec281c2 
Signed-off-by: yamkovoy <b.yamkovoy@gmail.com>
@yamkovoy yamkovoy mentioned this pull request Sep 28, 2023
Merged
@outoftardis
Copy link
Contributor

since there is now #416, should this pr be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 left review comments

@Arjentix Arjentix Arjentix left review comments

@appetrosyan appetrosyan appetrosyan requested changes

@WRRicht3r WRRicht3r WRRicht3r approved these changes

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@6r1d 6r1d Awaiting requested review from 6r1d

@nxsaken nxsaken Awaiting requested review from nxsaken nxsaken will be requested when the pull request is marked ready for review nxsaken is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yamkovoy @0x009922 @outoftardis @6r1d @appetrosyan @Arjentix @WRRicht3r