Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename iroha lib and bin #1185

Closed
takemiyamakoto opened this issue Jul 15, 2021 · 3 comments
Closed

Rename iroha lib and bin #1185

takemiyamakoto opened this issue Jul 15, 2021 · 3 comments
Assignees
@s8sato
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@takemiyamakoto
Copy link

Egor Ivkov, [11.06.21 11:32]
Ok, so I guess the points on which we agreed:

  1. Call iroha library - iroha_core
  2. Call iroha binary - iroha
@takemiyamakoto takemiyamakoto added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jul 15, 2021
@takemiyamakoto takemiyamakoto added this to the i2 Preview Release 1 milestone Jul 16, 2021
@takemiyamakoto takemiyamakoto removed this from the i2 Preview Release 1 milestone Sep 22, 2021
@takemiyamakoto takemiyamakoto added the good first issue Good for newcomers label Sep 22, 2021
@s8sato s8sato self-assigned this Oct 5, 2021
@s8sato
Copy link
Contributor

s8sato commented Oct 5, 2021 •
edited
Loading

Planning to do 3 steps

@s8sato
Copy link
Contributor

s8sato commented Oct 5, 2021 •
edited
Loading

Now renaming library iroha to iroha_core.
I have 5 "iroha"s ambiguous to me.
How should we handle these?

@e-ivkov
Copy link
Contributor

e-ivkov commented Oct 5, 2021

Now renaming library iroha to iroha_core. I have 5 "iroha"s ambiguous to me. How should we handle these?

  • The line about Metrics can be deleted as I remember it is outdated, we don't provide these metrics now.
  • In conf.py I think it can be left as it is
  • I don't have file iroha.conf locally, maybe @i1i1 you know what it is? I think this line can be deleted form gitignore
  • docker/ lines can also be removed from gitignore I think, we build right now inside of the container.

@s8sato s8sato mentioned this issue Oct 6, 2021
Merged
s8sato added a commit that referenced this issue Oct 11, 2021
@s8sato
Change crates name and path. Close #1185 (#1504)
0a6b130 
* Rename the library: `iroha` to `iroha_core`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Rename the binary: `iroha_cli` to `iroha`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Trim the path of every member of the workspace

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix WORKDIR in Dockerfile

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix paths in files outside cargo

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Remove outdated lines

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Rename crates: `actor_derive`, `futures_derive`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Update `README.md#project-structure`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix with rebase

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s8sato s8sato

Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@e-ivkov @takemiyamakoto @s8sato