Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about misconfiguration if faulty_peers = 0 and trusted peers count > 1 #1451

Closed
rkharisov opened this issue Sep 21, 2021 · 0 comments · Fixed by #1520
Closed
Assignees
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@rkharisov
Copy link

rkharisov commented Sep 21, 2021

Precondition: MAX_FAULTY_PEERS set to 0 or not set at all (in this case default value will be 0). Trusted peers contains more than 1 peers

Expected behaviour: There is some warning about misconfiguration in logs

Current behaviour: No hints about misconfiguration

Description: MAX_FAULTY_PEERS=0 effectively means peer will work in standalone mode without other peers, while trusted_peers.json provide a list of other peers in network. If MAX_FAULTY_PEERS=0 and trusted peers count > 1 that most probably means misconfiguration

@rkharisov rkharisov added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 21, 2021
@takemiyamakoto takemiyamakoto added the Bug Something isn't working label Sep 22, 2021
@GaroRobe GaroRobe self-assigned this Oct 12, 2021
@s8sato s8sato linked a pull request Oct 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants