Create an enum for Permission tokens and a cli helper to return all tokens

[e-ivkov]

Bogdan Mingela, [11.10.21 13:01]
Hi! Could I request to plan activities related to:

1. including Grant tokens values into the model scheme to have them formally defined, not be expected as 'arbitrary' string values
   ...
   Thanks!

@eadventurous

Egor Ivkov, [29.10.21 13:33]
[In reply to Bogdan Mingela]
The issue with the Grant tokens being string values comes from the fact that we wanted to separate core from permission_validators so that projects can add their own arbitrary validators while using the same core library. For this we needed dynamic (not strictly typed) values - for validators these are Box<dyn _> for tokens the String type was chosen. If we would have added and enum with all tokens there - then it would not be possible to use core with different validators and their corresponding tokens from different modules.

Egor Ivkov, [29.10.21 13:39]
With the possible permission checks with Triggers - there will be even more sense to keep tokens a String or byte value. As Triggers can be updated at runtime with corresponding permission tokens.

Ivan Rybin, [29.10.21 14:50]
We can probably make it like this: create a type which represent some specific permission token which implements Into trait for generic permission token

Ivan Rybin, [29.10.21 14:51]
On client side they can do dynamic conversion of it into generic token with strings

Egor Ivkov, [29.10.21 15:01]
[In reply to Ivan Rybin]
In general I like the idea, I think we can proceed with it. And give a cli helper for clients to get String reprs in json for example.

Ivan Rybin, [29.10.21 15:01]
[In reply to Egor Ivkov]
Btw we can even make an enum for gathering all tokens

Ivan Rybin, [29.10.21 15:02]
And just make conversion between this enum and generic permission token

Egor Ivkov, [29.10.21 15:04]
[In reply to Ivan Rybin]
Sure