Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Trusted peers json file feature #1636

Closed
appetrosyan opened this issue Nov 24, 2021 · 0 comments
Closed

Remove Trusted peers json file feature #1636

appetrosyan opened this issue Nov 24, 2021 · 0 comments
Assignees
@appetrosyan
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should

Comments

@appetrosyan
Copy link
Contributor

Motivation

I don’t ask for crypto. M◉⃤|<𓊖༒𓊖 Takemiya 武宮誠 (Sora.org - SORAMITSU), [24.11.21 12:56]
[In reply to Egor Ivkov]
it’s better to have less choices for the users

I don’t ask for crypto. M◉⃤|<𓊖༒𓊖 Takemiya 武宮誠 (Sora.org - SORAMITSU), [24.11.21 12:56]
so I would only have in the config file

In other words, we should only accept trusted peers as part of the initial config.json or via environment variables.
@e-ivkov e-ivkov changed the title Remove Trusted peers Remove Trusted peers json file feature Nov 24, 2021
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should labels Nov 24, 2021
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 19, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
7f500ac 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan mentioned this issue Dec 19, 2021
Merged
@appetrosyan appetrosyan self-assigned this Dec 19, 2021
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 19, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
5acd001 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 19, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
38884bd 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
3e27c58 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
d5a09e6 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
88c6a13 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
2208d63 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
4b56019 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
95f8770 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
f62ecdc 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Dec 20, 2021
@appetrosyan
[fix] hyperledger-iroha#1636: Remove trusted_peers.json.
03e2b5e 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue Dec 20, 2021
@appetrosyan
[fix] #1636, #1249: Remove trusted_peers.json and structopt (#1739)
cb37922 
* [fix] #1636: Remove `trusted_peers.json`.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* [refactor] #1249: Remove `structopt` from `iroha_core`.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* [fix] #1636: Remove `trusted_peers.json`.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appetrosyan appetrosyan

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appetrosyan