Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for all peers to commit genesis block by querying /status #1643

Closed
e-ivkov opened this issue Nov 29, 2021 · 0 comments
Closed

Wait for all peers to commit genesis block by querying /status #1643

e-ivkov opened this issue Nov 29, 2021 · 0 comments
Assignees
@e-ivkov
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should

Comments

@e-ivkov
Copy link
Contributor

e-ivkov commented Nov 29, 2021 •
edited
Loading

Egor Ivkov, [30 Nov 2021 19:03:23]
Actually now that we have status endpoint we can just wait in all tests until each peer has genesis by querying this endpoint and checking the number of blocks.

Egor Ivkov, [30 Nov 2021 19:03:38]
It should be simple to add this to test_network crate.

Egor Ivkov, [30 Nov 2021 19:04:01]
And we will no longer care about waiting for a specific fixed time

Aleksandr Petrosyan, [30 Nov 2021 19:05:23]
[In reply to Egor Ivkov]
This could scale to public networks too.

Egor Ivkov, [30 Nov 2021 19:06:04]
[In reply to Aleksandr Petrosyan]
That's what our DevOps wanted to do on deployment
@e-ivkov e-ivkov added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 29, 2021
@e-ivkov e-ivkov changed the title Wait for all peers for genesis block submission Wait for all peers to have committed genesis block by querying /status Nov 30, 2021
@e-ivkov e-ivkov changed the title Wait for all peers to have committed genesis block by querying /status Wait for all peers to commit genesis block by querying /status Nov 30, 2021
@e-ivkov e-ivkov self-assigned this Dec 1, 2021
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 1, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
c760c72 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 1, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
5895846 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
@appetrosyan appetrosyan added Bug Something isn't working Optimization Something isn't working as well as it should labels Dec 2, 2021
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 2, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
8d2035f 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 3, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
aef0bd0 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 3, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
03603a3 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 3, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
f6e1361 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 3, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
c100d44 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit to e-ivkov/iroha that referenced this issue Dec 3, 2021
@e-ivkov
[feature] hyperledger-iroha#1643: Wait for peers to commit genesis in…
84d6f9f 
… tests

Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
e-ivkov added a commit that referenced this issue Dec 6, 2021
@e-ivkov
[feature] #1643: Wait for peers to commit genesis in tests (#1655)
607b051 
Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-ivkov e-ivkov

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @e-ivkov