Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The fault tolerance capacity does not follow the topology change #1706

Closed
s8sato opened this issue Dec 8, 2021 · 0 comments
Closed

The fault tolerance capacity does not follow the topology change #1706

s8sato opened this issue Dec 8, 2021 · 0 comments
Assignees
@s8sato
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@s8sato
Copy link
Contributor

s8sato commented Dec 8, 2021 •
edited
Loading

Steps to Reproduce

Start the network of 3f+1 peers and remove one:

./iroha_client_cli peer unregister --address="iroha3:1340" --key="ed01208e351a70b6a603ed285d666b8d689b680865913ba03ce29fb7d13a166c4e7f1f"

Expected Behavior

f decrements

Actual Behavior

f is fixed, which results in:

  • When peers increase, relatively few of them can get the consensus
  • When peers decrease, they might never reach the consensus

2021-12-08T215424+090000

Possible Causes

Fixed Topology.max_faults, which

  • checks the length of the topology peers
  • defines the expected votes for the consensus

Possible Solution

Topology also updates .max_faults when its update
@s8sato s8sato added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Dec 8, 2021
@s8sato s8sato self-assigned this Dec 8, 2021
@s8sato s8sato changed the title Update max_faults with Topology update The fault tolerance capacity does not follow the topology change Dec 9, 2021
@s8sato s8sato mentioned this issue Dec 9, 2021
Merged
s8sato added a commit that referenced this issue Dec 11, 2021
@s8sato
[fix] #1706: Update max_faults with Topology update (#1710)
29e8e57 
* Update `max_faults` with Topology update

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Change `max_faults` type from `u32` to `usize`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Improve status test

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Apply review comments

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Trim docs

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Apply review comments

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato closed this as completed Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s8sato s8sato

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s8sato