Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Torii global state #1725

Closed
mversic opened this issue Dec 13, 2021 · 0 comments
Closed

Remove Torii global state #1725

mversic opened this issue Dec 13, 2021 · 0 comments
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Dec 13, 2021

As it is implemented at the moment, Torii has global state shared by all filters due to the limitations of the add_state method. The code is somewhat convoluted because there is the same set of variables in both Torii and ToriiState.

Make changes to add_state(implement it as macro_rules) to support fine tuning of what filters receive as state
@mversic mversic mentioned this issue Dec 13, 2021
Merged
@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 14, 2021
mversic added a commit that referenced this issue Dec 14, 2021
@mversic
[refactor] #1725: Remove global state in Torii (#1721)
e59c537 
* implement add_state macro_rules and remove `ToriiState`

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

* split router implementations in Torii for easier testing

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic closed this as completed Dec 14, 2021
s8sato added a commit to s8sato/iroha that referenced this issue Dec 27, 2021
@s8sato
Fix status term to telemetry according to hyperledger-iroha#1725
90afcb0 
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit to s8sato/iroha that referenced this issue Dec 27, 2021
@s8sato
Fix status term to telemetry according to hyperledger-iroha#1725
0f62529 
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit to s8sato/iroha that referenced this issue Dec 28, 2021
@s8sato
Fix status term to telemetry according to hyperledger-iroha#1725
5121ad9 
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
This was referenced Dec 28, 2021
Merged
Closed
s8sato added a commit that referenced this issue Dec 28, 2021
@s8sato
[fix] #1755: Minor fixes for #1743, #1725 (#1760)
3d85d89 
* Fix JSONs according to #1743 `Domain` struct change

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix `status` term to `telemetry` according to #1725

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix `status_address`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @mversic