-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong typing for socket addresses #1786
Comments
Could benefit from rust-lang/rust#82485 |
I remember I reverted use of |
True. There's also the question of The current best solution is to replace the OS-specific implementations of |
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
…ddresses Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Currently all socket addresses are stored as strings. This is not ideal, because we don't know if the configuration files should contain the protocol specifier or not. For example, there are many instances in the code, where a string check for presence of
http://
is done, and a format pre-pend.We should probably either use one of the
std::net
types, or (better), a custom type that can be converted into the types that we need.The text was updated successfully, but these errors were encountered: