Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sample configs from the Docker container #1883

Closed
s8sato opened this issue Feb 8, 2022 · 2 comments
Closed

Remove sample configs from the Docker container #1883

s8sato opened this issue Feb 8, 2022 · 2 comments
Assignees
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@s8sato
Copy link
Contributor

s8sato commented Feb 8, 2022

Aleksandr Petrosyan, [2022/02/08 15:19]
Another point that Bogdan raised is that we should stop including default configuration files inside containers. People boot up the container, see no error messages, assume everything is fine, when it isn't.

S Sato, [2022/02/08 16:30]
[In reply to Aleksandr Petrosyan]
The following would be one of the solutions:

S Sato, [2022/02/08 16:42]
[In reply to S Sato]
Not so much difference from directly writing environment section as current though

Aleksandr Petrosyan, [2022/02/08 16:42]
[In reply to S Sato]
This is a simplification, however.

Aleksandr Petrosyan, [2022/02/08 16:43]
If we can reduce the number of places where Iroha can be configured to just one, I don’t see an issue.

S Sato, [2022/02/08 16:57]
[In reply to Aleksandr Petrosyan]
Yes, at least we can merge peer/config.json into environment variables,
but instead, iroha_config will have to have dotenv

@s8sato s8sato added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 8, 2022
@appetrosyan appetrosyan added the api-changes Changes in the API for client libraries label Feb 9, 2022
@dmitrivenger
Copy link

@appetrosyan please change the title

@appetrosyan appetrosyan changed the title Demand explicit config specification on deployment Remove sample configs from the Docker container Mar 21, 2022
@appetrosyan
Copy link
Contributor

Done

@appetrosyan appetrosyan added the good first issue Good for newcomers label Apr 19, 2022
@appetrosyan appetrosyan self-assigned this May 6, 2022
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 6, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 6, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 8, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue May 8, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
mversic pushed a commit to mversic/iroha that referenced this issue May 13, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants