-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor permission tokens API #2052
Comments
After some consideration and failed experiments I can't come up with a satisfactory design that would allow us to both create permission tokens dynamically and have them as completely independent types, as opposed to specialized wrappers around stringly-typed If we don't have/expect to have any cases where one would like to create and use new permission tokens via e.g. smartcontracts, we could make them strongly-typed and predefined per iroha build. In the other case, I would propose bringing permission tokens more in line with other dynamically created entities: make them Identifiable and Registrable and require registering a token before granting it, like is the case with Roles. That would allow to easily query for all existing permission tokens and make them more consistent with everything else. I'm more in favor of the second approach, but I think it depends mostly on whether we have any use-cases for defining new permission tokens at run-time, if there are none, it would make sense to go with the first one. |
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Right now we have to identify
PermissionTokens
using some constant string. It makes sense for external API, but inside Iroha it could be strong typed.If someone has something to add, feel free to leave a comment
The text was updated successfully, but these errors were encountered: