-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyPair::new
invariant check
#2121
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
mversic
added a commit
that referenced
this issue
Apr 25, 2022
mversic
added a commit
to mversic/iroha
that referenced
this issue
May 2, 2022
…cted (hyperledger-iroha#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 4, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this issue
May 12, 2022
…cted (hyperledger-iroha#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
added a commit
to mversic/iroha
that referenced
this issue
May 13, 2022
…cted (hyperledger-iroha#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
added a commit
to mversic/iroha
that referenced
this issue
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When constructing a new
KeyPair
out of public and private key, it is not verified that the keys actually make a pair, i.e. the given public key doesn't have to correspond with the given private key. TheKeyPair::new
method should check that this invariant is maintained by theKeyPair
container. I would suggest that this can be done by signing some dummy payload with the private key and verifying the signature with the public key. Performance of this check is not of big consideration because this constructor is rarely used and most often cached in the applicationThe text was updated successfully, but these errors were encountered: