Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FindAssetDefinitionById query #2125

Closed
0x009922 opened this issue Apr 20, 2022 · 15 comments
Closed

Add FindAssetDefinitionById query #2125

0x009922 opened this issue Apr 20, 2022 · 15 comments
Assignees
@pesterev
Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

Make it possible to find an AssetDefinition by its AssetDefinitionId.
@0x009922 0x009922 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries labels Apr 20, 2022
@0x009922 0x009922 mentioned this issue Apr 20, 2022
Closed
@ritikBhandari
Copy link

hi,
Can I take up this issue if possible?

@appetrosyan
Copy link
Contributor

I thought you wanted to work on another issue?

@ritikBhandari
Copy link

yeah I did but I couldn't get any response for my next message. So I thought you must have other plans for that issue.

@appetrosyan
Copy link
Contributor

Yeah, I thought your previous message was a statement, rather than a question, regardless, if you kindly pick a slot in my calendar I could do some onboarding, and we'd be happy to receive your code contributions.

https://calendar.google.com/calendar/u/0?cid=cGV0cm9zeWFuQHNvcmFtaXRzdS5jby5qcA

@ritikBhandari
Copy link

Sure.
But just to be clear, which issue should I work on? Though both are related to adding queries and I'm comfortable taking both of them.

@ritikBhandari
Copy link

Also, can I know what is your time zone? Actually I'm comfortable either at morning or night but I dont know if it would be okay for you.

@appetrosyan
Copy link
Contributor

Re: issues, take whichever you like, but take one.

Re: time zone, UTC+4, but I can work around your schedule if you like.

@ritikBhandari
Copy link

ritikBhandari commented Apr 23, 2022 •
edited
Loading

I have selected 6-7pm (UTC+5:30) on 26th April. Let me know if you are fine with it or we can figure out another time frame suitable for both of us.

@appetrosyan
Copy link
Contributor

Good! Please use my personal meeting Zoom link.

@appetrosyan
Copy link
Contributor

CFT #2126

@appetrosyan
Copy link
Contributor

We discussed the main bits of information. If you need any extra help, please find me on the Hyperledger Discord #iroha.

@appetrosyan
Copy link
Contributor

@ritikBhandari When do you expect to start working on this issue?

@ritikBhandari
Copy link

I'm sorry my router is not working.

@ritikBhandari
Copy link

ritikBhandari commented Apr 26, 2022 •
edited
Loading

I'll start it today only. Actually I work at night so I'll start working on it from tonight

@ritikBhandari ritikBhandari mentioned this issue May 16, 2022
Closed
@0x009922 0x009922 mentioned this issue May 23, 2022
Closed
@pesterev pesterev self-assigned this May 25, 2022
pesterev added a commit to pesterev/iroha that referenced this issue May 25, 2022
@pesterev
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
e0bcb35 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev added a commit to pesterev/iroha that referenced this issue May 25, 2022
@pesterev
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
e9551e9 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
@pesterev pesterev mentioned this issue May 25, 2022
Merged
pesterev added a commit that referenced this issue May 26, 2022
@pesterev
[feature] #2125: Add FindAssetDefinitionById query
c2b599d 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev added a commit to pesterev/iroha that referenced this issue May 26, 2022
@pesterev
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
71616a2 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev added a commit to pesterev/iroha that referenced this issue May 26, 2022
@pesterev
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
8b59efb 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev referenced this issue in pesterev/iroha May 26, 2022
@pesterev
[feature] hyperledger#2125: Add FindAssetDefinitionById query
f1c33f1 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev referenced this issue in pesterev/iroha May 26, 2022
@pesterev
[feature] hyperledger#2125: Add FindAssetDefinitionById query
2d3a8dc 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
pesterev added a commit to pesterev/iroha that referenced this issue May 26, 2022
@pesterev
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
48fc783 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
appetrosyan pushed a commit that referenced this issue May 26, 2022
@pesterev @appetrosyan
[feature] #2125: Add FindAssetDefinitionById query
1f1c8d7 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
@0x009922
Copy link
Contributor Author

It is not tested in the explorer yet. Maybe it will be reopened again.

BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this issue Jul 8, 2022
@pesterev @BAStos525
[feature] hyperledger-iroha#2125: Add FindAssetDefinitionById query
991c881 
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pesterev pesterev

Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pesterev @appetrosyan @0x009922 @ritikBhandari