Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise trigger execution #2179

Closed
Arjentix opened this issue May 5, 2022 · 0 comments
Closed

Optimise trigger execution #2179

Arjentix opened this issue May 5, 2022 · 0 comments
Assignees
@Arjentix
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should

Comments

@Arjentix
Copy link
Contributor

Arjentix commented May 5, 2022

Right now all events will be passed through all triggers to check if a trigger should be executed.
Need to create different streams for different kind of events (Data, Pipeline, etc.) and different kind of triggers to reduce the number of useless check. This will require to make Trigger to be generic.
Also right now first fail in triggers execution will stop all others execution. That's not correct. If one trigger fails to run then it should be skipped
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries Optimization Something isn't working as well as it should labels May 5, 2022
@Arjentix Arjentix self-assigned this May 5, 2022
@Arjentix Arjentix mentioned this issue May 5, 2022
Merged
@Arjentix Arjentix changed the title Optimize trigger execution Optimise trigger execution May 5, 2022
Arjentix added a commit that referenced this issue May 11, 2022
@Arjentix
[feature] #2179: Optimise trigger execution (#2157)
89059b3 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
556ae95 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
6bffc7f 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
756e8b1 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
ffd5312 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
8298eba 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
05e26c6 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
c7e8223 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
cb317c2 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
380d708 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2179: Optimise trigger execution (hyperle…
03e574d 
…dger-iroha#2157)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Arjentix