Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making Asset-related operations generic #2204

Closed
appetrosyan opened this issue May 13, 2022 · 0 comments
Closed

Consider making Asset-related operations generic #2204

appetrosyan opened this issue May 13, 2022 · 0 comments
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@appetrosyan
Copy link
Contributor

Right now we have multiple very similar implementations of impl Execute for Mint<Asset, u32 | u64 | u128>, which have the potential of going out of sync with each other.

We need to refactor our existing implementations to make the triples of impl Mint, impl Burn and impl Transfer a generic blanket implementation.
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels May 13, 2022
@appetrosyan appetrosyan mentioned this issue May 13, 2022
Merged
@Erigara Erigara self-assigned this Jun 3, 2022
Erigara added a commit to Erigara/iroha that referenced this issue Jun 6, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
e87b700 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Jun 7, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
d453d6c 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Jun 7, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
bc8709c 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Jun 7, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
0b7b61b 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Jun 7, 2022
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Jun 10, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
29b1084 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Jun 10, 2022
@Erigara
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
6f60db0 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit that referenced this issue Jun 10, 2022
@Erigara
[refactor] #2204: Make Asset-related operations generic
5174255 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara closed this as completed Jun 10, 2022
omkar-mohanty pushed a commit to omkar-mohanty/iroha that referenced this issue Jun 11, 2022
@Erigara @omkar-mohanty
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
94db67e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
omkar-mohanty pushed a commit to omkar-mohanty/iroha that referenced this issue Jun 11, 2022
@Erigara @omkar-mohanty
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
002bf8c 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this issue Jul 8, 2022
@Erigara @BAStos525
[refactor] hyperledger-iroha#2204: Make Asset-related operations generic
e0cb958 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @Erigara