-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket communication noise #2247
Labels
Comments
mversic
added
Enhancement
New feature or request
question
Further information is requested
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
May 22, 2022
I suppose the answer lies in what can be sent as a receipt, and if we can encode the lower-level receipt as a higher-level control flow primitive. |
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Oct 24, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Oct 24, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Oct 26, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Oct 26, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this issue
Oct 26, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
appetrosyan
pushed a commit
that referenced
this issue
Oct 26, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Arjentix
pushed a commit
to Arjentix/iroha
that referenced
this issue
Dec 14, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
For data streaming we use websocket communication protocol over which we overly our own. Our communication protocol over an already established websocket for both events and block streaming (the only two we currently have) looks like this:
3.1 server sends an event
3.2 client responds with the event received message
Both the subscription accepted message and the event received message are redundant because they don't influence the control flow in any way and the fact that the message was received is guaranteed in the lower layers of abstraction as in TCP. While subscription accepted message is sent only once event received incurs a useless communication latency and should be removed.
The text was updated successfully, but these errors were encountered: