Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate decode() for decode_all() #2384

Closed
Arjentix opened this issue Jun 22, 2022 · 3 comments
Closed

Deprecate decode() for decode_all() #2384

Arjentix opened this issue Jun 22, 2022 · 3 comments
Assignees
@SamHSmith
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Arjentix
Copy link
Contributor

As mentioned in [this comment] we temporary allow users to send extra bytes, but we print warning message. This was done to help SDK-developers.

After everything is stabilized we have to remove this and return an error every time something with extra bytes was sent
@Arjentix Arjentix added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries Refactor Improvement to overall code quality labels Jun 22, 2022
@Arjentix Arjentix mentioned this issue Jun 22, 2022
Merged
@appetrosyan
Copy link
Contributor

@arndey @0x009922 , this is an important change, included in RC6.

@0x009922
Copy link
Contributor

Got it. @scale-codec/* doesn't emit anything extra on encode. Also it does this sanity check on decode by default.

@appetrosyan
Copy link
Contributor

You should test this against the RC.6 peer, and verify. The interpretations can silently diverge.

@appetrosyan appetrosyan changed the title Remove decode() when decode_all() have failed Deprecate decode() for decode_all() Jul 6, 2022
@SamHSmith SamHSmith self-assigned this Dec 2, 2022
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 4, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace with .
34501e5 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 4, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace decode with decode_all.
06019df 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 12, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace decode with decode_all.
3ec0c4d 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 12, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace decode with decode_all.
bd9e1d2 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 12, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace decode with decode_all.
955769a 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit to SamHSmith/iroha that referenced this issue Dec 13, 2022
@SamHSmith
[fix] hyperledger-iroha#2384: Replace decode with decode_all.
aa9ae6c 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
SamHSmith added a commit that referenced this issue Dec 13, 2022
@SamHSmith
[fix] #2384: Replace decode with decode_all.
cf8117e 
Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamHSmith SamHSmith

Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SamHSmith @appetrosyan @Arjentix @0x009922