Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Add state machine for signed Transaction #2478

Closed
Arjentix opened this issue Jul 13, 2022 · 0 comments
Closed

[refactor] Add state machine for signed Transaction #2478

Arjentix opened this issue Jul 13, 2022 · 0 comments
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Arjentix
Copy link
Contributor

Feature request

Add strong-typed transition from Transaction to SignedTransaction when it was signed

Motivation

Introducing a state machine pattern for Transaction when it was signed would help to understand some code using it and will decrease the amount of runtime errors when working with Transaction type

Who can help?

@Arjentix
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Jul 13, 2022
@mversic mversic added the Red label Jul 27, 2022
@s8sato s8sato mentioned this issue Aug 2, 2022
Closed
3 tasks
@Erigara Erigara self-assigned this Sep 5, 2022
@Erigara Erigara mentioned this issue Sep 6, 2022
Merged
@appetrosyan appetrosyan removed the Red label Sep 12, 2022
Erigara added a commit to Erigara/iroha that referenced this issue Sep 15, 2022
@Erigara
[refactor] hyperledger-iroha#2478: Add SignedTransaction
e9563bf 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
appetrosyan pushed a commit that referenced this issue Oct 7, 2022
@Erigara @appetrosyan
[refactor] #2478: Add SignedTransaction
6043c22 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@appetrosyan @Arjentix @Erigara @mversic