-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ffi_export
on trait implementations
#2488
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
after some thought, I'm not sure this is what should be done in case of every trait impl, at least not for the traits in the
|
Erigara
added a commit
that referenced
this issue
Aug 15, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 6, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 7, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
BAStos525
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 7, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 8, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
BAStos525
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
BAStos525
pushed a commit
to mversic/iroha
that referenced
this issue
Sep 9, 2022
…_export` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ffi_export
attribute can be attached on inherent impls. This is not a hard limitation, this attribute could be made to support trait impls as well. This is not a very difficult thing to do but requires the macro library to support parsing of associated types.If you take a look at
data_model::name
you can see thatName__from_str
is implemented manually and is essentially a wrapper aroundFromStr
implementation forName
. Impls such as this could be generated withffi_export
as well like this:which would generate, once macro is expanded, something like:
The text was updated successfully, but these errors were encountered: