Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a condition to update iroha2-base images #2732

Closed
s8sato opened this issue Sep 12, 2022 · 1 comment
Closed

Add a condition to update iroha2-base images #2732

s8sato opened this issue Sep 12, 2022 · 1 comment
Assignees
@BAStos525
Labels
CI Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@s8sato
Copy link
Contributor

s8sato commented Sep 12, 2022

Feature request

Don't build and publish the base image on every merge

Motivation

CI optimization

Who can help?

No response
@s8sato s8sato added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST CI labels Sep 12, 2022
@s8sato s8sato mentioned this issue Sep 12, 2022
Merged
@s8sato
Copy link
Contributor Author

s8sato commented Sep 13, 2022

Consider layer caching instead of having a base image
https://depot.dev/blog/docker-layer-caching-in-github-actions

@BAStos525 BAStos525 self-assigned this Sep 13, 2022
@BAStos525 BAStos525 mentioned this issue Sep 13, 2022
Merged
@s8sato s8sato mentioned this issue Sep 21, 2022
Closed
BAStos525 added a commit to BAStos525/soramitsu-iroha that referenced this issue Sep 21, 2022
@BAStos525
[ci] hyperledger-iroha#2732: Add a conditions to update iroha2-base i…
60b734e 
…mages and add PR labels

Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
BAStos525 added a commit that referenced this issue Sep 22, 2022
@BAStos525
[ci] #2732: Add a conditions to update iroha2-base images and add PR …
9eb9950 
…labels (#2743)

Signed-off-by: BAStos525 <jungle.vas@yandex.ru>

Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
appetrosyan pushed a commit that referenced this issue Oct 7, 2022
@BAStos525 @appetrosyan
[ci] #2732: Add a conditions to update iroha2-base images and add PR …
20adecf 
…labels (#2743)

Signed-off-by: BAStos525 <jungle.vas@yandex.ru>

Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BAStos525 BAStos525

Labels
CI Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s8sato @BAStos525