Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive HasOrigin trait automatically #2943

Closed
ilchu opened this issue Nov 11, 2022 · 0 comments
Closed

Derive HasOrigin trait automatically #2943

ilchu opened this issue Nov 11, 2022 · 0 comments
Assignees
@Erigara
Labels
Chore This is a small task that can be done at any point in time and is easier than others Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST macros

Comments

@ilchu
Copy link
Contributor

ilchu commented Nov 11, 2022

Feature request

Currently HasOrigin trait for events relies on manual updating of its variants should any of them change. Instead we could have a derive macro doing this automatically for us as was discussed a long time ago.

Motivation

Ergonomics, less leeway for error. Also see comment.

Who can help?

@Erigara @ilchu @s8sato
@ilchu ilchu added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST macros Chore This is a small task that can be done at any point in time and is easier than others labels Nov 11, 2022
@ilchu ilchu mentioned this issue Nov 11, 2022
Merged
@Erigara Erigara self-assigned this Feb 7, 2023
Erigara added a commit to Erigara/iroha that referenced this issue Feb 8, 2023
@Erigara
[refactor] hyperledger-iroha#2943: Derive HasOrigin
dd620e9 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
This was referenced Feb 8, 2023
Merged
Closed
Erigara added a commit to Erigara/iroha that referenced this issue Feb 13, 2023
@Erigara
[refactor] hyperledger-iroha#2943: Derive HasOrigin
916f5ad 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Feb 13, 2023
@Erigara
[refactor] hyperledger-iroha#2943: Derive HasOrigin
62dad1e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Feb 16, 2023
@Erigara
[refactor] hyperledger-iroha#2943: Derive HasOrigin
d8ddce8 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit that referenced this issue Feb 16, 2023
@Erigara
[refactor] #2943: Derive HasOrigin
a56c959 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
Chore This is a small task that can be done at any point in time and is easier than others Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST macros
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @ilchu @Erigara